Migrate from AICSImage to BioImage #130
Conversation
Co-authored-by: pr4deepr <[email protected]>
Without this, writing by the bioio-ome-tiff writer fails.
bioio-bioformats fails with dask use: bioio-devs/bioio-bioformats#40 After fixing reading, I got a validationerror when save_dir was not set, so I set save_dir to a temporary directory as in other tests.
|
@pr4deepr wanna approve the workflow to see if there are any further failures here? |
|
Well, that was disappointing 🤣 |
|
Ok looks eminently fixable 😅 👍 |
|
Python 3.8 and 3.9 errors are possibly due to bioio not supporting However, error with tests for 3.10 appear to be pydantic related? |
You mean only supporting, yes? And yes, that's what I meant by eminently fixable... But I got stuck with other work... 😅 |
|
(and yes the test matrix will need to be updated to only test 3.10+, which is fine since 3.9 is EOL.) |
|
Remind me why we can't use 3.11+? I think it's reasonable to drop 3.8-3.9 if we have to, because they're both end-of-life |
|
I think no reason @multimeric just needs updating the matrix |
|
I was just focused on getting stuff to run on my laptop when doing this work 😅 |
|
I'm not sure, Pradeep specifically called it out in d7bfefa |
|
that was still in aicsimageio land |
|
? |
|
Well if you think the migration to BioIO unblocks the versions, then feel free to update the CI matrix |
|
at any rate I'm doing the WEHI bioinformatics seminar next week (Tue Dec 2), maybe we can get together in person and hammer this out? CC @jamesyan-git |
|
I wanted 3.8 and 3.9 because of some software packages I used during analysis, specifically ilastik and cellprofiler apis. Having aicsimageio in the same environment made it complicated as well. Going ahead, it's going to be harder to maintain, so let's drop support for older python versions and add support for 3.11 & 3.12. If we need compatibility, will use older versions of napari-lattice. Will have to add this in docs.. |
3 participants
Closes #100
Supersedes #123
From #123:
New changes:
I ran into bioio-devs/bioio-bioformats#40 which
means bioio-bioformats is probably not a good thing to rely on for now --
many dask workflows will fail with bioio-bioformats-read images.
Currently, all tests are passing on my machine except
test_crop_workflow,which fails with a PyClesperanto_prototype error. I'm hoping that will not be
an issue in CI/win/linux machines, let's see.